Hi Shaoqin, On 7/24/23 09:39, Shaoqin Huang wrote: > According the talk[1], because the architecture get updated, what used to be a > RES1 bit becomes a functinal bit. So we can define the name for these bits, this > also increase the readability. > > [1] lore.kernel.org/ZLZQ6r4-9mVdg4Ry@monolith.localdoman > > v1: > https://lore.kernel.org/all/20230719031926.752931-1-shahuang@xxxxxxxxxx/ > Thanks, Eric for the suggestions: > - Rephrase the commit title in patch 1. > - Use the _BITULL(). > - Delete the SCTLR_EL1_RES1 and unwind its definition into > INIT_SCTLR_EL1_MMU_OFF. > > Shaoqin Huang (2): > arm64: Use _BITULL() to define SCTLR_EL1 bit fields > arm64: Define name for these bits used in SCTLR_EL1 for the series Reviewed-by: Eric Auger <eric.auger@xxxxxxxxxx> Eric > > lib/arm64/asm/sysreg.h | 32 ++++++++++++++++++++------------ > 1 file changed, 20 insertions(+), 12 deletions(-) >