On 7/24/2023 5:58 AM, Jason Gunthorpe wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
On Sat, Jul 22, 2023 at 12:17:34AM -0700, Brett Creeley wrote:
I wonder whether the logic about migration file can be generalized.
It's not very maintainable to have every migration driver implementing
their own code for similar functions.
Did I overlook any device specific setup required here?
There isn't device specific setup, but the other drivers were different
enough that it wasn't a straight forward task. I think it might be possible
to refactor the drivers to some common functionality here, but IMO this
seems like a task that can be further explored once this series is merged.
You keep saying that but, things seem to be getting worse. There are
alot of migration drivers being posted right now with alot of copy and
paste from mlx5.
I understand and agree with what you guys are saying. However, I was
also asked to simplify this code for our use case in v9, which I have
done. I’d like to get this finalized so that I have a chance to get to
the next step and maybe work with all involved to define what can be
commonized and how to get there.
Brett
Jason
