Re: [PATCH] KVM: x86:Fix warnings in debugfs.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 12/7/23 05:08, shijie001@xxxxxxxxxx wrote:
The following checkpatch warning is removed:
WARNING: Prefer seq_puts to seq_printf

Signed-off-by: Jie Shi <shijie001@xxxxxxxxxx>
---
  arch/x86/kvm/debugfs.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kvm/debugfs.c b/arch/x86/kvm/debugfs.c
index ee8c4c3496ed..a3e118397aa3 100644
--- a/arch/x86/kvm/debugfs.c
+++ b/arch/x86/kvm/debugfs.c
@@ -133,20 +133,20 @@ static int kvm_mmu_rmaps_stat_show(struct seq_file *m, void *v)
      mutex_unlock(&kvm->slots_lock);

      /* index=0 counts no rmap; index=1 counts 1 rmap */
-    seq_printf(m, "Rmap_Count:\t0\t1\t");
+    seq_puts(m, "Rmap_Count:\t0\t1\t");
      for (i = 2; i < RMAP_LOG_SIZE; i++) {
          j = 1 << (i - 1);
          k = (1 << i) - 1;
          seq_printf(m, "%d-%d\t", j, k);
      }
-    seq_printf(m, "\n");
+    seq_puts(m, "\n");

If you really want to clean this, then seq_putc() is more
appropriate.


      for (i = 0; i < KVM_NR_PAGE_SIZES; i++) {
          seq_printf(m, "Level=%s:\t", kvm_lpage_str[i]);
          cur = log[i];
          for (j = 0; j < RMAP_LOG_SIZE; j++)
              seq_printf(m, "%d\t", cur[j]);
-        seq_printf(m, "\n");
+        seq_puts(m, "\n");

Ditto.

      }

      ret = 0;




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux