Re: [PATCH v14 24/26] vfio: Move the IOMMU_CAP_CACHE_COHERENCY check in __vfio_register_dev()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 10, 2023 at 07:59:26PM -0700, Yi Liu wrote:
> The IOMMU_CAP_CACHE_COHERENCY check only applies to the physical devices
> that are IOMMU-backed. But it is now in the group code. If want to compile
> vfio_group infrastructure out, this check needs to be moved out of the group
> code.
> 
> Another reason for this change is to fail the device registration for the
> physical devices that do not have IOMMU if the group code is not compiled
> as the cdev interface does not support such devices.
> 
> Suggested-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Signed-off-by: Yi Liu <yi.l.liu@xxxxxxxxx>
> ---
>  drivers/vfio/group.c     | 10 ----------
>  drivers/vfio/vfio_main.c | 11 +++++++++++
>  2 files changed, 11 insertions(+), 10 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux