On Fri, 2023-07-14 at 18:16 +0800, WANG Xuerui wrote: > > > > > As all needed instructions have already upstream in binutils now and > > > > > binutils 2.41 will be released soon, I suggest again to introduce > > > > > AS_HAS_LVZ_EXTENSION and make KVM depend on AS_HAS_LVZ_EXTENSION. > > > > It is a good news that binutils 2.41 has supported LVZ assemble language. > > > > we will add AS_HAS_LVZ_EXTENSION support, however KVM need not depend on > > > > AS_HAS_LVZ_EXTENSION since bintuils 2.41 is not popularly used. yeap we > > > > need write beautiful code, also we should write code with pratical usage. I've raised this for a very early version of this series, but Paolo decided using .word here should be fine: https://lore.kernel.org/all/87268dce-1b5d-0556-7e65-2a75a7893cd1@xxxxxxxxxx/ So in this case we should respect the decision of the KVM reviewer. If this breaks Clang build, we should improve Clang to support using .word for hard coding an opcode. Frankly I'm quite frustrated by "a new architecture needs so many feature tests and hacks, here and there" and sometimes I just want to go laid-up in bed instead of writing code or porting the distro (Linux From Scratch). But today I just got [a board from another Chinese vendor targeting another new architecture] and to me they are doing things even worse... So maybe we are facing some inherent "no silver bullet engineering issue". -- Xi Ruoyao <xry111@xxxxxxxxxxx> School of Aerospace Science and Technology, Xidian University
