This patch do following things:
1. Update sar command in start function in /profilers/sar/sar.py,
because when i manual run '/usr/bin/sar -o %s %d 0' command, help
message is show up. Sames count number could not be 0, so use default
count.
2. Put os.kill in sar.py into try block to avoid traceback.
Sometimes it tried to kill an already terminated process which can
cause a traceback.
Signed-off-by: Feng Yang <fyang@xxxxxxxxxx>
---
client/profilers/sar/sar.py | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/client/profilers/sar/sar.py b/client/profilers/sar/sar.py
index fbe0639..e10156f 100644
--- a/client/profilers/sar/sar.py
+++ b/client/profilers/sar/sar.py
@@ -21,14 +21,17 @@ class sar(profiler.profiler):
logfile = open(os.path.join(test.profdir, "sar"), 'w')
# Save the sar data as binary, convert to text after the test.
raw = os.path.join(test.profdir, "sar.raw")
- cmd = "/usr/bin/sar -o %s %d 0" % (raw, self.interval)
+ cmd = "/usr/bin/sar -o %s %d " % (raw, self.interval)
p = subprocess.Popen(cmd, shell=True, stdout=logfile, \
stderr=subprocess.STDOUT)
self.pid = p.pid
def stop(self, test):
- os.kill(self.pid, 15)
+ try:
+ os.kill(self.pid, 15)
+ except OSError:
+ pass
def report(self, test):
--
1.5.5.6
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
