Re: [PATCH 02/10] x86/tdx: Use cmovc to save a label in TDX_MODULE_CALL asm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 02/10] x86/tdx: Use cmovc to save a label in TDX_MODULE_CALL asm
From: "Huang, Kai" <kai.huang@xxxxxxxxx>
Date: Thu, 13 Jul 2023 10:32:33 +0000
Accept-language: en-US
Cc: "Hansen, Dave" <dave.hansen@xxxxxxxxx>, "Christopherson,, Sean" <seanjc@xxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "pbonzini@xxxxxxxxxx" <pbonzini@xxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "Yamahata, Isaku" <isaku.yamahata@xxxxxxxxx>
In-reply-to: <400c0d11-fa14-cb1c-f6ed-02f850753e46@linux.intel.com>
References: <cover.1689151537.git.kai.huang@intel.com> <70784afc0a42d4dc1b1e743f90d89f7728496add.1689151537.git.kai.huang@intel.com> <400c0d11-fa14-cb1c-f6ed-02f850753e46@linux.intel.com>
User-agent: Evolution 3.48.4 (3.48.4-1.fc38)

On Wed, 2023-07-12 at 12:27 -0700, Sathyanarayanan Kuppuswamy wrote:
> 
> On 7/12/23 1:55 AM, Kai Huang wrote:
> > Change 'jnc .Lno_vmfailinvalid' to 'cmovc %rdi, %rax' to save the
> > .Lno_vmfailinvalid label in the TDX_MODULE_CALL asm macro.
> 
> You are removing the label, right? What use "save"?
 
Per comments to patch 10 I'll drop this patch, so doesn't matter anymore.

References:
- [PATCH 00/10] Unify TDCALL/SEAMCALL and TDVMCALL assembly
  - From: Kai Huang
- [PATCH 02/10] x86/tdx: Use cmovc to save a label in TDX_MODULE_CALL asm
  - From: Kai Huang
- Re: [PATCH 02/10] x86/tdx: Use cmovc to save a label in TDX_MODULE_CALL asm
  - From: Sathyanarayanan Kuppuswamy

Prev by Date: Re: [RFC 0/3] KVM: x86: introduce pv feature lazy tscdeadline
Next by Date: Re: [PATCH 07/10] x86/tdx: Extend TDX_MODULE_CALL to support more TDCALL/SEAMCALL leafs
Previous by thread: Re: [PATCH 02/10] x86/tdx: Use cmovc to save a label in TDX_MODULE_CALL asm
Next by thread: [PATCH 05/10] x86/tdx: Rename __tdx_module_call() to __tdcall()
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]