On Fri, Jul 07, 2023, Anish Moorthy wrote: > Done > > (somebody please let me know if these short "ack"/"done" messages are > frowned upon btw. Nobody's complained about it so far, but I'm not > sure if people consider it spam) I personally think that ack/done messages that don't add anything else to the conversation are useless. The bar for "anything else" can be very low, e.g. a simple "gotcha" can be valuable if it wraps up a conversation, but "accepting" every piece of feedback is a waste of everyone's time IMO as the expectation is that all review feedback will be addressed, either by a follow-up conversation or by modifying the patch in the next version, i.e. by *not* pushing back you are implicitly accepting feedback. And an "ack/done" isn't binding, i.e. doesn't magically morph into code and guarantee that the next version of the patch will actually contain the requested changes.
