Re: [PATCH v21 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

Subject: Re: [PATCH v21 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB
From: Thomas Huth <thuth@xxxxxxxxxx>
Date: Tue, 4 Jul 2023 14:27:03 +0200
Cc: qemu-devel@xxxxxxxxxx, borntraeger@xxxxxxxxxx, pasic@xxxxxxxxxxxxx, richard.henderson@xxxxxxxxxx, david@xxxxxxxxxx, cohuck@xxxxxxxxxx, mst@xxxxxxxxxx, pbonzini@xxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, ehabkost@xxxxxxxxxx, marcel.apfelbaum@xxxxxxxxx, eblake@xxxxxxxxxx, armbru@xxxxxxxxxx, seiden@xxxxxxxxxxxxx, nrb@xxxxxxxxxxxxx, nsg@xxxxxxxxxxxxx, berrange@xxxxxxxxxx, clg@xxxxxxxx
In-reply-to: <aef8accb-3576-2b10-a946-191a6be3e3e0@redhat.com>
References: <20230630091752.67190-1-pmorel@linux.ibm.com> <20230630091752.67190-4-pmorel@linux.ibm.com> <aef8accb-3576-2b10-a946-191a6be3e3e0@redhat.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 04/07/2023 13.40, Thomas Huth wrote:
...

Also, what about protected virtualization? Do you have to uses390_cpu_pv_mem_write() in case PV is enabled?

Never mind, I keep forgetting that CPU topology can't be used together withPV (I just noticed after reading patch 07/20).

Not sure ... but maybe a comment here in the code would help?

 Thomas

References:
- [PATCH v21 00/20] s390x: CPU Topology
  - From: Pierre Morel
- [PATCH v21 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB
  - From: Pierre Morel
- Re: [PATCH v21 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB
  - From: Thomas Huth