Hi,
On 2023/6/29 23:54, Bjorn Helgaas wrote:
On Thu, Jun 22, 2023 at 01:08:15PM +0800, Sui Jingfeng wrote:
Hi,
A nouveau developer(Lyude) from redhat send me a R-B,
Thanks for the developers of nouveau project.
Please allow me add a link[1] here.
[1] https://lore.kernel.org/all/0afadc69f99a36bc9d03ecf54ff25859dbc10e28.camel@xxxxxxxxxx/
1) Thanks for this. If you post another version of this series,
please pick up Lyude's Reviewed-by and include it in the relevant
patches (as long as you haven't made significant changes to the
code Lyude reviewed).
Yes, no significant changes. Just fix typo.
I also would like to add support for other DRM drivers.
But I think this deserve another patch.
Whoever applies this should automatically
pick up Reviewed-by/Ack/etc that are replies to the version being
applied, but they won't go through previous revisions to find them.
2) Please mention the commit to which the series applies. I tried to
apply this on v6.4-rc1, but it doesn't apply cleanly.
Since I'm a graphic driver developer, I'm using drm-tip.
I just have already pulled, it still apply cleanly on drm-tip.
3) Thanks for including cover letters in your postings. Please
include a little changelog in the cover letter so we know what
changed between v6 and v7, etc.
No change between v6 and v7,
it seems that it is because the mailbox don't allow me to sending too
many mails a day.
so some of the patch is failed to delivery because out of quota.
4) Right now we're in the middle of the v6.5 merge window, so new
content, e.g., this series, is too late for v6.5. Most
maintainers, including me, wait to merge new content until the
merge window closes and a new -rc1 is tagged. This merge window
should close on July 9, and people will start merging content for
v6.6, typically based on v6.5-rc1.
I'm wondering
Would you will merge all of the patches in this series (e.g. including
the patch for drm/amdgpu(7/8) and drm/radeon(8/8)) ?
Or just part of them?
Emm, I don't know because my patch seems across different subsystem of
Linux kernel.
There is also a developer for AMDGPU (Mario) give me a R-B for the
patch-0002 of this series.
So, at least, PATCH-0001, PATCH-0002, PATCH-0003, PATCH-0004, PATCH-0006
are already OK(got reviewed by).
Those 5 patch are already qualified to be merged, I think.
I means that if you could merge those 5 patch first, then there no need
to send another version again.
I will refine the rest patch with more details and description.
I'm fear of making too much noise.
Bjorn
