> On Jun 25, 2023, at 11:18 PM, Andrew Jones <andrew.jones@xxxxxxxxx> wrote: > > !! External Email > > On Sun, Jun 25, 2023 at 11:07:11PM +0000, Nadav Amit wrote: >> From: Nadav Amit <namit@xxxxxxxxxx> >> >> Debugging tests that run on EFI is hard because the debug information is >> not included in the EFI file. Dump it into a separeate .debug file to >> allow the use of gdb or pretty_print_stacks script. >> >> Signed-off-by: Nadav Amit <namit@xxxxxxxxxx> >> >> --- >> >> v1->v2: >> * Making clean should remove .debug [Andrew] > > I forgot to point out in the previous review that not only do we need > to clean but also add *.debug to .gitignore I will do that for v3. I did not (and still do not) understand what change you want for run_tests.sh so I would indeed appreciate if you do this one.