> From: Brett Creeley <bcreeley@xxxxxxx> > Sent: Saturday, June 17, 2023 3:02 AM > > > >> > >> +#define PDS_LM_DEV_NAME PDS_CORE_DRV_NAME "." > >> PDS_DEV_TYPE_LM_STR > >> + > > > > should this name include a 'vfio' string? > > This aligns with what our DSC/firmware expects, so no it's not needed. /** * pds_client_register - Link the client to the firmware * @pf_pdev: ptr to the PF driver struct * @devname: name that includes service into, e.g. pds_core.vDPA The comment mentions vDPA which confused me on whether the client should include a keyword of client to differentiate. e.g. here the name is "pds_core.LM". If both VFIO/vDPA want to support live migration with pds_core will there be a conflict or fine for multiple drivers registering to a same service?