On Mon, Jun 19 2023 at 08:00, Li, Xin3 wrote: > To me it's better to keep the changes in one patch, thus the differences > are more obvious. The rename to vector_schedule_cleanup() can be obviously done first. > We need a second patch to do vector cleanup in lapic_offline() in case the > vector cleanup timer has not expired. Right. I was lazy and just put a WARN_ON() there under the assumption that you will figure it out. But a second patch? We don't switch things over into a broken state first and then fix it up afterwards. Thanks, tglx