On 6/19/23 09:41, Philippe Mathieu-Daudé wrote:
hw/net/i82596.c access the global 'address_space_memory' calling the ld/st_phys() API. address_space_memory is declared in "exec/address-spaces.h". Currently this header is indirectly pulled in via another header. Explicitly include it to avoid when refactoring unrelated headers: hw/net/i82596.c:91:23: error: use of undeclared identifier 'address_space_memory'; did you mean 'address_space_destroy'? return ldub_phys(&address_space_memory, addr); ^~~~~~~~~~~~~~~~~~~~ address_space_destroy Signed-off-by: Philippe Mathieu-Daudé<philmd@xxxxxxxxxx> --- hw/net/i82596.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx> r~