On 6/15/2023 11:56 PM, Tian, Kevin wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
From: Brett Creeley <brett.creeley@xxxxxxx>
Sent: Saturday, June 3, 2023 6:03 AM
This is the initial framework for the new pds_vfio device driver. This
does the very basics of registering the PDS PCI device and configuring
it as a VFIO PCI device.
With this change, the VF device can be bound to the pds_vfio driver on
the host and presented to the VM as the VF's device type.
while this should be generic to multiple PDS device types this patch only
supports the ethernet VF. worth a clarification here.
+static const struct pci_device_id
+pds_vfio_pci_table[] = {
no need to break line.
Must have missed this one. Thanks.
+
+MODULE_DESCRIPTION(PDS_VFIO_DRV_DESCRIPTION);
+MODULE_AUTHOR("Advanced Micro Devices, Inc.");
author usually describes the personal name plus mail address.
Will fix. Thanks.
+
+ err = vfio_pci_core_init_dev(vdev);
+ if (err)
+ return err;
+
+ pds_vfio->vf_id = pci_iov_vf_id(pdev);
pci_iov_vf_id() could fail.
Good catch. I will for failure on the next revision. Thanks.
