On Mon, Jun 05, 2023, Anish Moorthy wrote: > On Sat, Jun 3, 2023 at 9:58 AM Isaku Yamahata <isaku.yamahata@xxxxxxxxx> wrote: > > > > UPM or gmem uses size instead of len. Personally I don't have any strong > > preference. It's better to converge. (or use union to accept both?) > > I like "len" because to me it implies a contiguous range, whereas > "size" does not: but it's a minor thing. Converging does seem good > though. Eh, I don't think we need to converge the two. "size" is far more common when describing the properties of a file (the gmem case), whereas "length" is often used when describing the number of bytes being accessed by a read/write. I.e. they're two different things, so using different words to describe them isn't a bad thing. Though I suspect by "UPM or gmem" Isakue really meant "struct kvm_memory_attributes". I don't think we need to converge that one either, though I do agree that "size" isn't the greatest name. I vote to rename kvm_memory_attributes's "size" to either "nr_bytes" or "len".
