On 24.03.2010, at 10:32, Avi Kivity wrote: > On 03/22/2010 12:49 PM, Alexander Graf wrote: >> When we fail to create a VCPU we have no way to tell our callers that something >> failed. So the caller happily uses a completely broken state. >> >> This code should become deprecated in the process of converting qemu-kvm to >> qemu anyways, so let's not care about remdeling it but just bailing out when >> something breaks. Also give the user a hint on why the VCPU_CREATE might have >> failed. >> >> This fixes a segmentation fault with -smp> VCPU_MAX in the host kernel. >> >> > > Applied, thanks. Note, kvm reports the number of supported vcpus using KVM_CAP_NR_VCPUS, so we can fail in vl.c. Sounds like the right fix to do for qemu.git. As soon as SMP support is in there. Alex-- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html