On 12/06/2023 16:59, Nadav Amit wrote:>
Thanks. I am still struggling to run the tests on my environment. Why the
heck frame-pointers are disabled on arm64? Perhaps I’ll send my patch to
enable them (and add one on exception handling).
I am afraid I don't know why it's omitted. It seems that x86 and arm
keep it:
$> git grep KEEP_FRAME_POINTER
Makefile:frame-pointer-flag=-f$(if
$(KEEP_FRAME_POINTER),no-,)omit-frame-pointer
arm/Makefile.arm:KEEP_FRAME_POINTER := y
x86/Makefile.common:KEEP_FRAME_POINTER := y
It should be straightforward to add it for an arm64 build with debugging
enabled, perhaps along with your other patch.
Anyhow, I was wondering, since it was not clearly mentioned in the
cover-letter: which tests were run on what environment? Did they all pass
or are there still some open issues?
[ I ask for my enabling efforts. Not blaming or anything. ]
Thanks again for the hard work, Nikos (and Andrew).
With this series and Drew's patch "arch-run: Extend timeout when booting
with UEFI", on a standard Ubuntu 22.04.2 LTS (gcc version 11.3.0 and
QEMU emulator version 6.2.0), I get the following results:
$> ./run_tests.sh
PASS selftest-setup (2 tests)
PASS selftest-vectors-kernel (3 tests)
PASS selftest-vectors-user (2 tests)
PASS selftest-smp (1 tests)
PASS pci-test (1 tests)
PASS pmu-cycle-counter (2 tests)
PASS pmu-event-introspection (1 tests)
PASS pmu-event-counter-config (3 tests)
PASS pmu-basic-event-count (11 tests, 1 skipped)
PASS pmu-mem-access (3 tests, 1 skipped)
PASS pmu-sw-incr (5 tests, 1 skipped)
FAIL pmu-chained-counters (6 tests, 3 unexpected failures)
FAIL pmu-chained-sw-incr (2 tests, 2 unexpected failures)
FAIL pmu-chain-promotion (7 tests, 2 unexpected failures)
FAIL pmu-overflow-interrupt (7 tests, 2 unexpected failures, 1 skipped)
SKIP gicv2-ipi
SKIP gicv2-mmio
SKIP gicv2-mmio-up
SKIP gicv2-mmio-3p
PASS gicv3-ipi (3 tests)
SKIP gicv2-active
PASS gicv3-active (1 tests)
PASS its-introspection (5 tests)
PASS its-trigger (6 tests)
SKIP its-migration
SKIP its-pending-migration
SKIP its-migrate-unmapped-collection
PASS psci (5 tests, 1 skipped)
PASS timer (18 tests)
SKIP micro-bench (test marked as manual run only)
PASS cache (1 tests)
PASS debug-bp (6 tests)
SKIP debug-bp-migration
PASS debug-wp (8 tests)
SKIP debug-wp-migration
PASS debug-sstep (1 tests)
SKIP debug-sstep-migration
which is the same results I get when I build without --enable-efi,
except for psci which requires ERRATA_6c7a5dce22b3=y to enable the
cpu-on test. For this, I think we need to implement support for the
ERRATA_* environmental variable.
Thanks,
Nikos
