Re: [Autotest] [PATCH] Monotonic time test: Don't force static compilation of time_test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 23, 2010 at 1:56 PM, Lucas Meneghel Rodrigues
<lmr@xxxxxxxxxx> wrote:
> On Tue, Mar 23, 2010 at 3:25 PM, Martin Bligh <mbligh@xxxxxxxxxx> wrote:
>> +cc:md (he wrote the test).
>>
>> On Tue, Mar 23, 2010 at 11:13 AM, Lucas Meneghel Rodrigues
>> <lmr@xxxxxxxxxx> wrote:
>>> The Makefile for the monotonic_test C program forces static
>>> compilation of the object files. Since we are compiling the
>>> code already, not having a static binary doesn't make much
>>> of a difference on the systems we are running this test.
>>>
>>> As the static compilation might fail in some boxes, just remove
>>> this constraint from the Makefile.
>>
>> I presume this was to fix some Google interdependency.
>> Is it actually breaking something? If not, seems safer to leave it?
>> If so, we'll have to fix one end or the other ;-)
>
> Yes, I can't get a static build on a Fedora 13 box by no means, that's
> why I looked into what was going wrong and cooked this patch. If
> someone has any suggestions of what I need to do to work around this,
> let me know.

OK, sounds like Michael is happy - and there's a real problem to fix.
LGTM - go ahead and apply it.

Thanks,

M.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux