Capitalize subject to match ("Tidy ...") On Thu, Jun 08, 2023 at 07:43:19PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng <suijingfeng@xxxxxxxxxxx> > > This patch replaces the leading space with a tab and removes the double > blank line, no functional change. Can you move this to the end of the series? The functional changes are more likely to be backported, and I think the backport may be a little easier without the cleanup in the middle. > /* we could in theory hand out locks on IO and mem > - * separately to userspace but it can cause deadlocks */ > + * separately to userspace but it can cause deadlocks > + */ Since you're touching this anyway, can you update it to the conventional multi-line comment style: /* * We could in theory ... */ And capitalize "We", add a period at end, and rewrap to fill 78 columns or so? Same for other comments below. > +++ b/include/linux/vgaarb.h > @@ -23,9 +23,7 @@ > * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > - * DEALINGS > - * IN THE SOFTWARE. > - * > + * DEALINGS IN THE SOFTWARE. > */ Can you make a separate patch to replace this entire copyright notice with the appropriate SPDX-License-Identifier header? Documentation/process/license-rules.rst has details. Bjorn