On Thu, 8 Jun 2023 09:25:26 +0200 Cédric Le Goater <clg@xxxxxxxxxx> wrote: > On 6/8/23 01:09, Alex Williamson wrote: > > For consistency with pci and platform, push the vfio-fsl-mc option into a > > sub-menu. > > > > Reviewed-by: Cédric Le Goater <clg@xxxxxxxxxx> > > Reviewed-by: Eric Auger <eric.auger@xxxxxxxxxx> > > Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx> > > --- > > drivers/vfio/fsl-mc/Kconfig | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/vfio/fsl-mc/Kconfig b/drivers/vfio/fsl-mc/Kconfig > > index 597d338c5c8a..d2757a1114aa 100644 > > --- a/drivers/vfio/fsl-mc/Kconfig > > +++ b/drivers/vfio/fsl-mc/Kconfig > > @@ -1,3 +1,5 @@ > > +menu "VFIO support for FSL_MC bus devices" > > + > > The menu entry can be empty on arches not supporting the FSL-MC bus. > I think this needs an extra : > > depends on ARM64 || COMPILE_TEST Good catch, but shouldn't we just move up the FSL_MC_BUS depends to the menu level? Thanks, Alex > > config VFIO_FSL_MC > > tristate "VFIO support for QorIQ DPAA2 fsl-mc bus devices" > > depends on FSL_MC_BUS > > @@ -8,3 +10,5 @@ config VFIO_FSL_MC > > fsl-mc bus devices using the VFIO framework. > > > > If you don't know what to do here, say N. > > + > > +endmenu >
