On Wed, 2023-06-07 at 08:48 -0700, Dave Hansen wrote: > On 6/4/23 07:27, Kai Huang wrote: > > As a step of initializing the TDX module, the kernel needs to tell the > > TDX module which memory regions can be used by the TDX module as TDX > > guest memory. > ... > > Signed-off-by: Kai Huang <kai.huang@xxxxxxxxx> > > Reviewed-by: "Huang, Ying" <ying.huang@xxxxxxxxx> > > Reviewed-by: Isaku Yamahata <isaku.yamahata@xxxxxxxxx> > > This is rather short on reviews from folks who do a lot of memory > hotplug work. Partly because I don't see any of them cc'd. David and Kirill are Cc'ed :) linux-mm list is Cc'ed too. > > Can you wrangle some mm reviews on this, please? Yes in v8 I followed your suggestion to ask Cc MM people (David/Oscar/Andrew) to take a look, and David said it looked good to him. https://lore.kernel.org/lkml/cover.1670566861.git.kai.huang@xxxxxxxxx/T/#mffb978d157c99da598d6354d55650952c425c6fd I then removed Oscar and Andrew from Cc list since this patch doesn't touch core-MM memory hotplug but only uses memory notifier. I'll ask Kirill to help to review. Hi David, I appreciate if you could give your Acked-by or Reviewed-by if this patch looks good to you? Thanks :) > > For the x86 side (and <sigh> because this patch probably took two years > to coalesce <double sigh>): > > Reviewed-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> Thanks!