On Fri, May 26, 2023 at 05:44:26PM -0600, Yu Zhao wrote: > +/* > + * Architectures that implement kvm_arch_test_clear_young() should override > + * kvm_arch_has_test_clear_young(). > + * > + * kvm_arch_has_test_clear_young() is allowed to return false positive, i.e., it > + * can return true if kvm_arch_test_clear_young() is supported but disabled due > + * to some runtime constraint. In this case, kvm_arch_test_clear_young() should Is it a typo here? s/kvm_arch_test_clear_young/kvm_arch_has_test_clear_young/. > +static inline int mmu_notifier_clear_young(struct mm_struct *mm, > + unsigned long start, > + unsigned long end) > +{ > + return 0; > +} > + This looks irrelevant to the patch but a fix for commit 1d7715c676a1 ("mmu-notifier: add clear_young callback") instead.