On Thu, Jun 01, 2023 at 02:42:38PM -0600, Alex Williamson wrote: > On Mon, 29 May 2023 14:47:59 -0300 > > +config VFIO_PCI_CORE > > + tristate "VFIO support for PCI devices" > > + select VFIO_VIRQFD > > + select IRQ_BYPASS_MANAGER > > + help > > + Base support for VFIO drivers that support PCI devices. At least one > > + of the implementation drivers must be selected. > > As enforced by what? Doesn't need to be enforced. Probably should have said "should" > This is just adding one more layer of dependencies in order to select > the actual endpoint driver that is actually what anyone cares about. This is making the kconfig more logical and the menu structure better organized. We eliminate the need for the drivers to set special depends because the if covers them all. > I don't see why we wouldn't just make each of the variant drivers > select VFIO_PCI_CORE. Thanks, It can be done, but it seems more fragile. Jason
