On Thu, May 25, 2023 at 09:21:23AM -0600, Alex Williamson wrote: > On Tue, 16 May 2023 21:28:35 -0300 > Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > > > On Tue, May 16, 2023 at 03:09:14PM -0600, Alex Williamson wrote: > > > > > > +# SPDX-License-Identifier: GPL-2.0-only > > > > +config NVGPU_VFIO_PCI > > > > + tristate "VFIO support for the GPU in the NVIDIA Grace Hopper Superchip" > > > > + depends on ARM64 || (COMPILE_TEST && 64BIT) > > > > + select VFIO_PCI_CORE > > > > > > I think this should be a 'depends on' as well, that's what we have for > > > the other vfio-pci variant drivers. > > > > It should be removed completely, AFAICT: > > > > config VFIO_PCI > > tristate "Generic VFIO support for any PCI device" > > select VFIO_PCI_CORE > > > > Ensures it is turned on > > > > if VFIO_PCI > > source "drivers/vfio/pci/mlx5/Kconfig" > > endif > > The source command actually comes after the VFIO_PCI endif, the mlx5 > Kconfig is sourced if PCI && MMU. Ah, I forgot we made the VFIO_PCI_CORE a hidden menu choice, so yeah, it should be select everywhere and we can't use the IF trick. > In fact I think it's the current variant drivers that are incorrect to > make use of 'depends on', this makes those variant drivers implicitly > depend on VFIO_PCI Yes Jason
