When trying to build kvmtool with clang, it warned about two problems, which are fatal since we use "-Werror". Patch 1/2 is an easy one fixing an obvious bug (not sure why GCC didn't warn). Patch 2/2 removes an ugly hack which clang didn't want to let pass. This patch admittedly implements the most tedious solution to this problem, but I didn't want to just throw in a "__maybe_unused" (or "__used", as kvmtool puts it). If that solution is a bit over the top, let me know, maybe there is better solution which doesn't require to touch every user of the virtio endianess conversion functions - or __maybe_unused is OK after all. Cheers, Andre Andre Przywara (2): option parsing: fix type of empty .argh parameter virtio: sanitise virtio endian wrappers arm/include/arm-common/kvm-config-arch.h | 2 +- builtin-run.c | 2 +- include/kvm/parse-options.h | 7 ++-- include/kvm/virtio.h | 53 ++++++++++++++---------- virtio/9p.c | 2 +- virtio/blk.c | 8 ++-- virtio/console.c | 6 +-- virtio/core.c | 37 +++++++++-------- virtio/net.c | 6 +-- virtio/scsi.c | 20 ++++----- 10 files changed, 77 insertions(+), 66 deletions(-) -- 2.25.1
