On 5/16/2023 7:14 PM, Tian, Kevin wrote: >> From: Alex Williamson <alex.williamson@xxxxxxxxxx> >> Sent: Wednesday, May 17, 2023 6:53 AM >> >> On Thu, 11 May 2023 08:44:27 -0700 >> Reinette Chatre <reinette.chatre@xxxxxxxxx> wrote: >> >>> Changes since V4: >>> - V4: >> https://lore.kernel.org/lkml/cover.1682615447.git.reinette.chatre@xxxxxxxxx >> / >>> - Add Kevin's Reviewed-by tag as applicable. >>> - Treat non-existing INTx interrupt context as kernel bug with WARN. This >>> exposed an issue in the scenario where INTx mask/unmask may occur >> without >>> INTx enabled. This is fixed by obtaining the interrupt context later >>> (right before use) within impacted functions: vfio_pci_intx_mask() and >>> vfio_pci_intx_unmask_handler(). (Kevin) >>> - Treat pci_irq_vector() returning '0' for a MSI/MSI-X interrupt as a kernel >>> bug via a WARN instead of ignoring this value. (Kevin) >>> - Improve accuracy of comments. (Kevin) >>> - Please refer to individual patches for local changes. >> >> Looks good to me. >> >> Kevin, do you want to add any additional reviews or check the changes >> made based on your previous comments? >> > > Good to me too. I've given the remaining reviewed-by's. Thank you very much Alex and Kevin. Reinette
