On Fri, May 12, 2023 at 6:48 AM Conor Dooley <conor@xxxxxxxxxx> wrote: > > On Thu, May 11, 2023 at 11:25:41PM +0100, Conor Dooley wrote: > > On Thu, May 11, 2023 at 05:22:48PM +0800, Haibo Xu wrote: > > > KVM_GET_REG_LIST API will return all registers that are available to > > > KVM_GET/SET_ONE_REG APIs. It's very useful to identify some platform > > > regression issue during VM migration. > > > > > > Since this API was already supported on arm64, it'd be straightforward > > > to enable it on riscv with similar code structure. > > > > Applied on top of v6.4-rc1 this breaks the build :/ > > I lied, I forgot W=1 is enabled for the allmodconfig builds in the > patchwork automation. > The warnings are trivial to fix, so you should fix them anyway! > sure, I will fix them in the next version. Thanks, Haibo > > warning: Function parameter or member 'vcpu' not described in 'kvm_riscv_vcpu_num_regs' > > warning: Function parameter or member 'uindices' not described in 'kvm_riscv_vcpu_copy_reg_indices' > > warning: Function parameter or member 'vcpu' not described in 'kvm_riscv_vcpu_copy_reg_indices' > > > > You have a bunch of kerneldoc comments (the ones with /**) that are not > > valid kerneldoc. Apparently allmodconfig catches that! > > > > Cheers, > > Conor. > >