On Thu, May 11, 2023 at 05:18:31PM +0800, Binbin Wu wrote: >> > + if (sign_ext_bit > 0) >> > + *la = (sign_extend64(*la, sign_ext_bit) & ~BIT_ULL(63)) | >> > + (*la & BIT_ULL(63)); >> nit: curly braces are needed. >Even if it's only one statement (although splited to two lines), curly braces >are needed? I was under the impression somehow -- braces are needed if the statement is split into two lines. But Sean said [1] curly braces are not needed in this case. Thus, please disregard my comment. [1]: https://lore.kernel.org/all/Y9B9Ey1hK9A7NDVb@xxxxxxxxxx/
