On Wed, May 10, 2023 at 3:35 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > Yeah, when I speed read the series, several of the conversions stood out as being > "wrong". My (potentially unstated) idea was that KVM would only signal > KVM_EXIT_MEMORY_FAULT when the -EFAULT could be traced back to a user access, > i.e. when the fault _might_ be resolvable by userspace. Well, you definitely tried to get the idea across somehow- even in my cover letter here, I state > As a first step, KVM_CAP_MEMORY_FAULT_INFO is introduced. This > capability is meant to deliver useful information to userspace (i.e. the > problematic range of guest physical memory) when a vCPU fails a guest > memory access. So the fact that I'm doing something more here is unintentional and stems from unfamiliarity with all of the ways in which KVM does (or does not) perform user accesses. Sean, besides direct_map which other patches did you notice as needing to be dropped/marked as unrecoverable errors?
