On Mon, May 8, 2023 at 8:23 PM Mingwei Zhang <mizhang@xxxxxxxxxx> wrote: > > Add MSR_IA32_TSX_CTRL into msrs_to_save[] to explicitly tell userspace to > save/restore the register value during migration. Missing this may cause > userspace that relies on KVM ioctl(KVM_GET_MSR_INDEX_LIST) fail to port the > value to the target VM. > > In addition, there is no need to add MSR_IA32_TSX_CTRL when > ARCH_CAP_TSX_CTRL_MSR is not supported in kvm_get_arch_capabilities(). So > add the checking in kvm_probe_msr_to_save(). > > Fixes: c11f83e0626b ("KVM: vmx: implement MSR_IA32_TSX_CTRL disable RTM functionality") > Reported-by: Jim Mattson <jmattson@xxxxxxxxxx> > Signed-off-by: Mingwei Zhang <mizhang@xxxxxxxxxx> > --- Sign... missed the following two Reviewed-by... Reviewed-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx> Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx> Since this is probably the final version, I hope Sean or Paolo would help add them up before merging it. Appreciate your help. Thanks. -Mingwei