Re: [PATCH v2] KVM: VMX: add MSR_IA32_TSX_CTRL into msrs_to_save

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 8, 2023 at 10:28 AM Jim Mattson <jmattson@xxxxxxxxxx> wrote:
>
> On Sun, May 7, 2023 at 6:54 PM Xiaoyao Li <xiaoyao.li@xxxxxxxxx> wrote:
> >
> > On 5/5/2023 2:18 AM, Mingwei Zhang wrote:
> > > Add MSR_IA32_TSX_CTRL into msrs_to_save[] to explicitly tell userspace to
> > > save/restore the register value during migration. Missing this may cause
> > > userspace that relies on KVM ioctl(KVM_GET_MSR_INDEX_LIST) fail to port the
> > > value to the target VM.
> > >
> > > In addition, there is no need to add MSR_IA32_TSX_CTRL when
> > > ARCH_CAP_TSX_CTRL_MSR is not supported in guest. So add the checking in
> > > kvm_probe_msr_to_save().
> > >
> > > Fixes: b07a5c53d42a ("KVM: vmx: use MSR_IA32_TSX_CTRL to hard-disable TSX on guest that lack it")
> >
> > I wonder it's the fix for this commit.
> >
> > Apart from this,
> >
> > Reviewed-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx>
>
> I concur.
>
> How about:
>
> Fixes: ea732b38b341 ("KVM: vmx: implement MSR_IA32_TSX_CTRL disable
> RTM functionality")
>
> Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>

Will send a v3 with the update of the "Fixes"




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux