On Fri, May 5, 2023 at 5:55 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > ... > My preference is to make it a VM-scoped ioctl(), if it ends up being a KVM ioctl() > and not a common syscall. If the file isn't tightly coupled to a single VM, then > punching a hole is further complicated by needing to deal with invalidating multiple > regions that are bound to different @kvm instances. It's not super complex, but > AFAICT having the ioctl() be system-scoped doesn't add value, e.g. I don't think > having one VM own the memory will complicate even if/when we get to the point where > VMs can share "private" memory, and the gmem code would still need to deal with > grabbing a module reference. Copyless migration would be a scenario where "private" memory may need to be shared between source and target VMs depending on how migration support is implemented. Regards, Vishal