Re: [PATCH RFC v2 6/9] target/loongarch: Implement kvm_arch_init_vcpu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/27/23 08:26, Tianrui Zhao wrote:
+static void kvm_loongarch_vm_stage_change(void *opaque, bool running,

Typo:                           state

+    uint64_t counter_value;

I know naming is hard, but this is so generic it is difficult to determine what it does. Perhaps kvm_state_counter? A comment would also be helpful, even with a renaming.


r~



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux