On Mon, May 01, 2023 at 11:27:23PM +0100, Nikos Nikoleris wrote: > On 01/05/2023 12:21, Andrew Jones wrote: ... > > > https://github.com/relokin/kvm-unit-tests/pull/new/target-efi-upstream-v5 > > > > Thanks for the quick fixes. Can you update your tree and make an MR? I > > no longer use github.com/rhdrjones/kvm-unit-tests. I use > > > > https://gitlab.com/jones-drew/kvm-unit-tests.git > > > > You mean a MR into your repo and to the branch arm/queue, don't you? I've > tried doing that but I get an error: "Target branch "arm/queue" does not > exist", but it allows me to create a MR into other repos. Am I doing > something wrong? I'm not sure what's happening unless it's looking for the arm/queue branch on the main gitlab kvm-unit-tests repo instead of mine. > > My branch on gitlab: > > https://gitlab.com/nnikoleris/kvm-unit-tests/-/tree/target-efi-upstream-v6-pre Thanks. I grabbed the patches and applied to arm/queue, https://gitlab.com/jones-drew/kvm-unit-tests/-/commits/arm/queue > Do you want me to add your patch as well? Or are you going to add it > afterwards? We can do the additional runtime stuff on top. I have a couple other script changes too and I think Shaoqin is looking at how to better cope with migration tests. > Meanwhile, I've tried adding support for booting using a fdt. I > think it's not too hard, but I wouldn't mind merging this series first and > looking at the patches for the fdt support later. I'm also anxious to get this merged, but I'm a little reluctant to take it without DT, since we may find other issues once we boot the tests with DT. I also know how it's easy, at least for me, to let stuff get dropped when their priorities reduce. If you have time now, how about we poke at it until the end of the week? With some luck, it'll be sorted out and we'll also have the x86 ack, which I'd like to get, by then. Thanks, drew