On Thu, 27 Apr 2023 07:05:37 +0000 "Liu, Yi L" <yi.l.liu@xxxxxxxxx> wrote: > > From: Tian, Kevin <kevin.tian@xxxxxxxxx> > > Sent: Thursday, April 27, 2023 2:36 PM > > > > > From: Liu, Yi L <yi.l.liu@xxxxxxxxx> > > > Sent: Wednesday, April 26, 2023 10:54 PM > > > > > > -static inline bool vfio_device_is_noiommu(struct vfio_device *vdev) > > > +static inline int vfio_device_set_noiommu(struct vfio_device *device) > > > { > > > - return IS_ENABLED(CONFIG_VFIO_NOIOMMU) && > > > - vdev->group->type == VFIO_NO_IOMMU; > > > + device->noiommu = IS_ENABLED(CONFIG_VFIO_NOIOMMU) && > > > + device->group->type == VFIO_NO_IOMMU; > > > + return 0; > > > > Just void. this can't fail. > > Hmmm. Yes, before below commit, it cannot fail. Maybe this can be > converted to int later. > > https://lore.kernel.org/kvm/20230426150321.454465-22-yi.l.liu@xxxxxxxxx/T/#u AFAICT with the comments on the next patch, this change is not at all justified within this series and should be dropped. Thanks, Alex