Em Thu, Mar 18, 2010 at 05:31:06PM +0800, Zhang, Yanmin escreveu:
> From: Zhang, Yanmin <yanmin_zhang@xxxxxxxxxxxxxxx>
>
> Parameter --pid (or -p) of perf currently means a thread-wide collection.
> For exmaple, if a process whose id is 8888 has 10 threads, 'perf top -p 8888'
> just collects the main thread statistics. That's misleading. Users are
> used to attach a whole process when debugging a process by gdb. To follow
> normal usage style, the patch change --pid to process-wide collection and
> add --tid (-t) to mean a thread-wide collection.
>
> Usage example is:
> #perf top -p 8888
> #perf record -p 8888 -f sleep 10
> #perf stat -p 8888 -f sleep 10
> Above commands collect the statistics of all threads of process 8888.
>
> Signed-off-by: Zhang Yanmin <yanmin_zhang@xxxxxxxxxxxxxxx>
Just did visual inspection of the three patches, all sane, except for
some coding style nits, don't worry right now for that, I'll fix them up
myself, but please take those into account int the future, highlight
below.
> ---
>
> diff -Nraup linux-2.6_tip0317_statrecord/tools/perf/builtin-record.c linux-2.6_tip0317_statrecordpid/tools/perf/builtin-record.c
> --- linux-2.6_tip0317_statrecord/tools/perf/builtin-record.c 2010-03-18 13:48:39.578181540 +0800
> +++ linux-2.6_tip0317_statrecordpid/tools/perf/builtin-record.c 2010-03-18 14:28:41.449631936 +0800
> + mmap_array[nr_cpu][counter][thread_index].mask = mmap_pages*page_size - 1;
> + mmap_array[nr_cpu][counter][thread_index].base = mmap(NULL, (mmap_pages+1)*page_size,
Spaces around +, *, etc
> + PROT_READ|PROT_WRITE, MAP_SHARED, fd[nr_cpu][counter][thread_index], 0);
> + if (mmap_array[nr_cpu][counter][thread_index].base == MAP_FAILED) {
> + error("failed to mmap with %d (%s)\n", errno, strerror(errno));
> + exit(-1);
> + }
> + } else {
> + all_tids=malloc(sizeof(pid_t));
Ditto here for =
> + if (!all_tids)
> + return -ENOMEM;
> +
> + all_tids[0] = target_tid;
> + thread_num = 1;
> + }
> +
> + for (i = 0; i < MAX_NR_CPUS; i++) {
> + for (j = 0; j < MAX_COUNTERS; j++) {
> + fd[i][j] = malloc(sizeof(int)*thread_num);
> + mmap_array[i][j] = malloc(
> + sizeof(struct mmap_data)*thread_num);
Ditto
> + if (!fd[i][j] || !mmap_array[i][j])
> + return -ENOMEM;
> + }
> + }
> + event_array = malloc(
> + sizeof(struct pollfd)*MAX_NR_CPUS*MAX_COUNTERS*thread_num);
Ditto
Should be, I suggest:
event_array = malloc((sizeof(struct pollfd) * MAX_NR_CPUS *
MAX_COUNTERS * thread_num));
Anyway, I'll fix some of these while merging, now.
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
