On Fri, Apr 21, 2023 at 5:15 AM Robert Hoo <robert.hoo.linux@xxxxxxxxx> wrote: > > IIUC, you could say: in this on demand paging test case, even > duplicate copy/continue doesn't do harm anyway. Am I right? It's probably more accurate to say that it never happens in the first place. I've added a sentence here, > > > > + /* See the note about EEXISTs in the UFFDIO_COPY branch. */ > > > > > > Personally I would suggest copy the comments here. what if some day above > > > code/comment was changed/deleted? > > > > You might be right: on the other hand, if the comment ever gets > > updated then it would have to be done in two places. Anyone to break > > the tie? :) > > The one who updates the place is responsible for the comments. make sense?:) Fair enough, done.