On Thu, Apr 20, 2023 at 04:34:39PM -0700, Anish Moorthy wrote: > On Thu, Apr 20, 2023 at 1:53 PM Peter Xu <peterx@xxxxxxxxxx> wrote: > > > > Totally not familiar with nested, just a pure question on whether all the > > kvm_vcpu_map() callers will be prepared to receive this -EFAULT yet? > > The return values of this function aren't being changed: I'm just > setting some extra state in the kvm_run_struct in the case where this > function already returns -EFAULT. Ah, I was wrongly assuming there'll be more -EFAULTs after you enable the new memslot flag KVM_MEM_ABSENT_MAPPING_FAULT. But then when I re-read your patch below I see that the new flag only affects __kvm_faultin_pfn(). Then I assume that's fine, thanks. -- Peter Xu