On Wed, Apr 19, 2023 at 7:00 AM Hoo Robert <robert.hoo.linux@xxxxxxxxx> wrote: > > +static inline bool kvm_slot_fault_on_absent_mapping( > > + const struct kvm_memory_slot *slot) > > Strange line break. Fixed: there's now a single indent on the second line. > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index f3be5aa49829a..7cd0ad94726df 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -1525,6 +1525,9 @@ static int check_memory_region_flags(const struct kvm_userspace_memory_region *m > > valid_flags |= KVM_MEM_READONLY; > > Is it better to also via kvm_vm_ioctl_check_extension() rather than > #ifdef __KVM_HAVE_READONLY_MEM? Probably, that's unrelated though so I won't change it here
