Re: [kvm-unit-tests PATCH v2 0/3] Improve stack pretty printing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/04/2023 20.50, Nina Schoetterl-Glausch wrote:
I noticed some bugs/deficiencies in the pretty_print_stacks script.
Namely, it doesn't cope with 0 addresses, which might occur on s390x
when backtracing through a interrupt stack frame. Since an interrupt is
not a function call, the calling convention doesn't apply and we cannot
tell where the stack is.

Additionally, the script stops printing the stack if addr2line cannot
determine the line number, instead of skipping the printing of the
source.

Lastly, the file path determination was broken for me because I use git
worktrees and there being symlinks in the paths.
The proposed change works for me and fixes the issue.

Thanks! Since there were no objections or other suggestions, I went ahead and pushed the three patches now.

 Thomas





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux