On Tue, Apr 04, 2023 at 12:01:37PM -0700, Brett Creeley wrote: > @@ -30,13 +34,23 @@ pds_vfio_pci_probe(struct pci_dev *pdev, > > dev_set_drvdata(&pdev->dev, &pds_vfio->vfio_coredev); > pds_vfio->pdev = pdev; > + pds_vfio->pdsc = pdsc_get_pf_struct(pdev); This should not be a void *, it has a type, looks like it is 'struct pdsc *' - comment applies to all the places in both series that dropped the type here. Jason