On 03/17/2010 04:00 PM, Glauber Costa wrote:
On Tue, Mar 09, 2010 at 03:27:02PM +0200, Avi Kivity wrote:
On 02/26/2010 10:12 PM, Glauber Costa wrote:
It is actually not necessary to call a tpr function to save and load cr8,
as cr8 is part of the processor state, and thus, it is much easier
to just add it to CPUState.
As for apic base, wrap kvm usages, so we can call either the qemu device,
or the in kernel version.
}
+static void kvm_set_apic_base(CPUState *env, uint64_t val)
+{
+ if (!kvm_irqchip_in_kernel())
+ cpu_set_apic_base(env, val);
What if it is in kernel? Just ignored? Doesn't seem right.
At this point it is right, because there is no irqchip in kernel yet.
In a later patch, irqchip in kernel begins to exist, and this function
gets filled.
Ok. In the future please code things like that without the if (), and
add it when you introduce the other side. Helps fend off nit-pickers.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
