On 4/10/23 01:14, Xin Li wrote: > This patch set enables FRED for x86-64. I'm worried we're just in a patchbomb-once-a-week mode with FRED at this point. There wasn't a single comment on v7 so, of course, here's v8 a week later. FRED is a rare CPU feature because it's universally wanted. Us software folks have been begging for it for a looooooooong time. Is there anyone out there that has any doubts that the kernel will support (this) FRED eventually? The code also looks pretty reasonable. I do think it's missing some Documentation, and the cover letter is bit sparse. It would be nice to see some high-level information about things like, for instance, why there needs to be FRED refactoring for NMI/#PF/#DB/#MC specifically, but not other exceptions. There also aren't any new selftests. I faintly recall some tweak to the selftests recently that was FRED-oriented, but I'd still expect all the selftests that poke at the entry code to be perturbed by this a bit. Basically, if anyone else has been procrastinating on reviewing this set, now is probably the time to dig in. (I'll include myself in that category, btw)
