On Sun, Apr 09, 2023 at 05:36:02PM +0800, kernel test robot wrote: > Hi Ricardo, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on kvm/queue] > [also build test ERROR on mst-vhost/linux-next linus/master v6.3-rc5 next-20230406] > [cannot apply to kvmarm/next kvm/linux-next] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Ricardo-Koller/KVM-arm64-Rename-free_removed-to-free_unlinked/20230409-143229 > base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue > patch link: https://lore.kernel.org/r/20230409063000.3559991-6-ricarkol%40google.com > patch subject: [PATCH v7 04/12] KVM: arm64: Add kvm_pgtable_stage2_split() > config: arm64-defconfig (https://download.01.org/0day-ci/archive/20230409/202304091707.ALABRVCG-lkp@xxxxxxxxx/config) > compiler: aarch64-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/c94328e3e8b2d2d873503360ea730c87f4a03301 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Ricardo-Koller/KVM-arm64-Rename-free_removed-to-free_unlinked/20230409-143229 > git checkout c94328e3e8b2d2d873503360ea730c87f4a03301 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Link: https://lore.kernel.org/oe-kbuild-all/202304091707.ALABRVCG-lkp@xxxxxxxxx/ > > All errors (new ones prefixed by >>): > > In file included from include/linux/bitfield.h:10, > from arch/arm64/kvm/hyp/pgtable.c:10: > arch/arm64/kvm/hyp/pgtable.c: In function 'stage2_split_walker': > >> include/linux/container_of.h:20:54: error: 'struct kvm_s2_mmu' has no member named 'split_page_cache' > 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ > | ^~ > include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert' > 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) > | ^~~~ > include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert' > 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ > | ^~~~~~~~~~~~~ > include/linux/container_of.h:20:23: note: in expansion of macro '__same_type' > 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ > | ^~~~~~~~~~~ > arch/arm64/kvm/hyp/pgtable.c:1340:15: note: in expansion of macro 'container_of' > 1340 | mmu = container_of(mc, struct kvm_s2_mmu, split_page_cache); > | ^~~~~~~~~~~~ > include/linux/compiler_types.h:338:27: error: expression in static assertion is not an integer > 338 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b)) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert' > 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) > | ^~~~ > include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert' > 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ > | ^~~~~~~~~~~~~ > include/linux/container_of.h:20:23: note: in expansion of macro '__same_type' > 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ > | ^~~~~~~~~~~ > arch/arm64/kvm/hyp/pgtable.c:1340:15: note: in expansion of macro 'container_of' > 1340 | mmu = container_of(mc, struct kvm_s2_mmu, split_page_cache); > | ^~~~~~~~~~~~ > In file included from include/uapi/linux/posix_types.h:5, > from include/uapi/linux/types.h:14, > from include/linux/types.h:6, > from include/linux/kasan-checks.h:5, > from include/asm-generic/rwonce.h:26, > from arch/arm64/include/asm/rwonce.h:71, > from include/linux/compiler.h:247, > from include/linux/build_bug.h:5: > >> include/linux/stddef.h:16:33: error: 'struct kvm_s2_mmu' has no member named 'split_page_cache' > 16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER) > | ^~~~~~~~~~~~~~~~~~ > include/linux/container_of.h:23:28: note: in expansion of macro 'offsetof' > 23 | ((type *)(__mptr - offsetof(type, member))); }) > | ^~~~~~~~ > arch/arm64/kvm/hyp/pgtable.c:1340:15: note: in expansion of macro 'container_of' > 1340 | mmu = container_of(mc, struct kvm_s2_mmu, split_page_cache); > | ^~~~~~~~~~~~ > -- > In file included from include/linux/bitfield.h:10, > from arch/arm64/kvm/hyp/nvhe/../pgtable.c:10: > arch/arm64/kvm/hyp/nvhe/../pgtable.c: In function 'stage2_split_walker': > >> include/linux/container_of.h:20:54: error: 'struct kvm_s2_mmu' has no member named 'split_page_cache' > 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ > | ^~ > include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert' > 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) > | ^~~~ > include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert' > 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ > | ^~~~~~~~~~~~~ > include/linux/container_of.h:20:23: note: in expansion of macro '__same_type' > 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ > | ^~~~~~~~~~~ > arch/arm64/kvm/hyp/nvhe/../pgtable.c:1340:15: note: in expansion of macro 'container_of' > 1340 | mmu = container_of(mc, struct kvm_s2_mmu, split_page_cache); > | ^~~~~~~~~~~~ > include/linux/compiler_types.h:338:27: error: expression in static assertion is not an integer > 338 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b)) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert' > 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) > | ^~~~ > include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert' > 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ > | ^~~~~~~~~~~~~ > include/linux/container_of.h:20:23: note: in expansion of macro '__same_type' > 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ > | ^~~~~~~~~~~ > arch/arm64/kvm/hyp/nvhe/../pgtable.c:1340:15: note: in expansion of macro 'container_of' > 1340 | mmu = container_of(mc, struct kvm_s2_mmu, split_page_cache); > | ^~~~~~~~~~~~ > In file included from include/uapi/linux/posix_types.h:5, > from include/uapi/linux/types.h:14, > from include/linux/types.h:6, > from include/linux/kasan-checks.h:5, > from include/asm-generic/rwonce.h:26, > from arch/arm64/include/asm/rwonce.h:71, > from include/linux/compiler.h:247, > from include/linux/build_bug.h:5: > >> include/linux/stddef.h:16:33: error: 'struct kvm_s2_mmu' has no member named 'split_page_cache' > 16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER) > | ^~~~~~~~~~~~~~~~~~ > include/linux/container_of.h:23:28: note: in expansion of macro 'offsetof' > 23 | ((type *)(__mptr - offsetof(type, member))); }) > | ^~~~~~~~ > arch/arm64/kvm/hyp/nvhe/../pgtable.c:1340:15: note: in expansion of macro 'container_of' > 1340 | mmu = container_of(mc, struct kvm_s2_mmu, split_page_cache); > | ^~~~~~~~~~~~ > > > vim +20 include/linux/container_of.h > > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 9 > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 10 /** > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 11 * container_of - cast a member of a structure out to the containing structure > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 12 * @ptr: the pointer to the member. > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 13 * @type: the type of the container struct this is embedded in. > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 14 * @member: the name of the member within the struct. > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 15 * > 7376e561fd2e01 Sakari Ailus 2022-10-24 16 * WARNING: any const qualifier of @ptr is lost. > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 17 */ > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 18 #define container_of(ptr, type, member) ({ \ > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 19 void *__mptr = (void *)(ptr); \ > e1edc277e6f6df Rasmus Villemoes 2021-11-08 @20 static_assert(__same_type(*(ptr), ((type *)0)->member) || \ > e1edc277e6f6df Rasmus Villemoes 2021-11-08 21 __same_type(*(ptr), void), \ > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 22 "pointer type mismatch in container_of()"); \ > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 23 ((type *)(__mptr - offsetof(type, member))); }) > d2a8ebbf8192b8 Andy Shevchenko 2021-11-08 24 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests > Hi, The fix is to move the commit introducing KVM_CAP_ARM_EAGER_SPLIT_CHUNK_SIZE right before this one, like this: KVM: arm64: Rename free_removed to free_unlinked KVM: arm64: Add KVM_PGTABLE_WALK flags for skipping CMOs and BBM TLBIs KVM: arm64: Add helper for creating unlinked stage2 subtrees KVM: arm64: Export kvm_are_all_memslots_empty() KVM: arm64: Add KVM_CAP_ARM_EAGER_SPLIT_CHUNK_SIZE KVM: arm64: Add kvm_pgtable_stage2_split() KVM: arm64: Refactor kvm_arch_commit_memory_region() KVM: arm64: Add kvm_uninit_stage2_mmu() KVM: arm64: Split huge pages when dirty logging is enabled KVM: arm64: Open-code kvm_mmu_write_protect_pt_masked() KVM: arm64: Split huge pages during KVM_CLEAR_DIRTY_LOG KVM: arm64: Use local TLBI on permission relaxation Thanks, Ricardo
