Re: [PATCH v3 4/5] KVM: selftests: Fixup test asserts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Same shortlog problem.

On Tue, Mar 07, 2023, Aaron Lewis wrote:
> Fix up both ASSERT_PMC_COUNTING and ASSERT_PMC_NOT_COUNTING in the
> pmu_event_filter_test by adding additional context in the assert
> message.

I 100% agree that the asserts are flawed, but in the context of changelogs, "fix"
almost always implies something is broken.  In this case, what is being asserted
is completely ok, it's only the messages that are bad.

Easiest thing is to just describe the change and explain why it's desirable, and
dodge the question of whether or not this should be considered a fix.

    Provide the actual vs. expected count in the PMU event filter test's
    asserts instead of relying on pr_info() to provide the context, e.g. so
    that all information needed to triage a failure is readily available even
    if the environment in which the test is run captures only the assert
    itself.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux