LOL, the shortlog is hilariously generic. I realize it's annoying to have to clarify what test is affected, but it's not exactly hard, e.g. KVM: selftests: Add a common helper for the PMU event filter guest code On Tue, Mar 07, 2023, Aaron Lewis wrote: > Split out the common parts of the Intel and AMD guest code into a > helper function. This is in preparation for adding > additional counters to the test. Similar whining here Split out the common parts of the Intel and AMD guest code in the PMU event filter test into a helper function. This is in preparation for adding additional counters to the test. > > No functional changes intended. > > Signed-off-by: Aaron Lewis <aaronlewis@xxxxxxxxxx> > --- > .../kvm/x86_64/pmu_event_filter_test.c | 31 ++++++++++++------- > 1 file changed, 20 insertions(+), 11 deletions(-) > > diff --git a/tools/testing/selftests/kvm/x86_64/pmu_event_filter_test.c b/tools/testing/selftests/kvm/x86_64/pmu_event_filter_test.c > index bad7ef8c5b92..f33079fc552b 100644 > --- a/tools/testing/selftests/kvm/x86_64/pmu_event_filter_test.c > +++ b/tools/testing/selftests/kvm/x86_64/pmu_event_filter_test.c > @@ -100,6 +100,17 @@ static void check_msr(uint32_t msr, uint64_t bits_to_flip) > GUEST_SYNC(0); > } > > +static uint64_t test_guest(uint32_t msr_base) test_guest() is again too generic, and arguably inaccurate, e.g. it's not really testing anything, just running code and capturing event counts. How about run_and_measure_loop()?
