Re: [PATCH v3 02/12] vfio/pci: Only check ownership of opened devices in hot reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 02/12] vfio/pci: Only check ownership of opened devices in hot reset
From: Eric Auger <eric.auger@xxxxxxxxxx>
Date: Wed, 5 Apr 2023 17:14:34 +0200
Cc: "Liu, Yi L" <yi.l.liu@xxxxxxxxx>, "alex.williamson@xxxxxxxxxx" <alex.williamson@xxxxxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "joro@xxxxxxxxxx" <joro@xxxxxxxxxx>, "robin.murphy@xxxxxxx" <robin.murphy@xxxxxxx>, "cohuck@xxxxxxxxxx" <cohuck@xxxxxxxxxx>, "nicolinc@xxxxxxxxxx" <nicolinc@xxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "mjrosato@xxxxxxxxxxxxx" <mjrosato@xxxxxxxxxxxxx>, "chao.p.peng@xxxxxxxxxxxxxxx" <chao.p.peng@xxxxxxxxxxxxxxx>, "yi.y.sun@xxxxxxxxxxxxxxx" <yi.y.sun@xxxxxxxxxxxxxxx>, "peterx@xxxxxxxxxx" <peterx@xxxxxxxxxx>, "jasowang@xxxxxxxxxx" <jasowang@xxxxxxxxxx>, "shameerali.kolothum.thodi@xxxxxxxxxx" <shameerali.kolothum.thodi@xxxxxxxxxx>, "lulu@xxxxxxxxxx" <lulu@xxxxxxxxxx>, "suravee.suthikulpanit@xxxxxxx" <suravee.suthikulpanit@xxxxxxx>, "intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx" <intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx>, "intel-gfx@xxxxxxxxxxxxxxxxxxxxx" <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, "Hao, Xudong" <xudong.hao@xxxxxxxxx>, "Zhao, Yan Y" <yan.y.zhao@xxxxxxxxx>, "Xu, Terrence" <terrence.xu@xxxxxxxxx>, "Jiang, Yanting" <yanting.jiang@xxxxxxxxx>
In-reply-to: <ZC1eg8ZqwkfKuTDx@nvidia.com>
References: <20230401144429.88673-1-yi.l.liu@intel.com> <20230401144429.88673-3-yi.l.liu@intel.com> <844faa5c-2968-2a4f-8a70-900f359be1a0@redhat.com> <DS0PR11MB75290339DD0FD467146D4655C3939@DS0PR11MB7529.namprd11.prod.outlook.com> <fc87191d-2e79-83c3-b5ba-7f8b1083988a@redhat.com> <DS0PR11MB7529441450FE32DC9578C6B8C3939@DS0PR11MB7529.namprd11.prod.outlook.com> <5781064c-8742-d37d-57dc-7a7238e948d5@redhat.com> <ZC1eg8ZqwkfKuTDx@nvidia.com>
Reply-to: eric.auger@xxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0

Hi Jason,

On 4/5/23 13:41, Jason Gunthorpe wrote:
> On Tue, Apr 04, 2023 at 05:59:01PM +0200, Eric Auger wrote:
>
>>> but the hot reset shall fail as the group is not owned by the user.
>> sure it shall but I fail to understand if the reset fails or the device
>> plug is somehow delayed until the reset completes.
> It is just racy today - vfio_pci_dev_set_resettable() doesn't hold any
> locks across the pci_walk_bus() check to prevent hot plug in while it is
> working on the reset.

OK thanks

Eric
>
> Jason
>

References:
- [PATCH v3 00/12] Introduce new methods for verifying ownership in vfio PCI hot reset
  - From: Yi Liu
- [PATCH v3 02/12] vfio/pci: Only check ownership of opened devices in hot reset
  - From: Yi Liu
- Re: [PATCH v3 02/12] vfio/pci: Only check ownership of opened devices in hot reset
  - From: Eric Auger
- RE: [PATCH v3 02/12] vfio/pci: Only check ownership of opened devices in hot reset
  - From: Liu, Yi L
- Re: [PATCH v3 02/12] vfio/pci: Only check ownership of opened devices in hot reset
  - From: Eric Auger
- RE: [PATCH v3 02/12] vfio/pci: Only check ownership of opened devices in hot reset
  - From: Liu, Yi L
- Re: [PATCH v3 02/12] vfio/pci: Only check ownership of opened devices in hot reset
  - From: Eric Auger
- Re: [PATCH v3 02/12] vfio/pci: Only check ownership of opened devices in hot reset
  - From: Jason Gunthorpe

Prev by Date: Re: [PATCH v3 11/12] iommufd: Define IOMMUFD_INVALID_ID in uapi
Next by Date: RE: [PATCH v3 11/12] iommufd: Define IOMMUFD_INVALID_ID in uapi
Previous by thread: Re: [PATCH v3 02/12] vfio/pci: Only check ownership of opened devices in hot reset
Next by thread: [PATCH v3 03/12] vfio/pci: Move the existing hot reset logic to be a helper
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]