On Tue, Apr 4, 2023 at 11:46 AM Oliver Upton <oliver.upton@xxxxxxxxx> wrote: > > On Mon, Apr 03, 2023 at 02:08:29PM -0700, Raghavendra Rao Ananta wrote: > > On Wed, Mar 29, 2023 at 5:59 PM Oliver Upton <oliver.upton@xxxxxxxxx> wrote: > > > > > > On Mon, Feb 06, 2023 at 05:23:36PM +0000, Raghavendra Rao Ananta wrote: > > > > Define __kvm_tlb_flush_range_vmid_ipa() (for VHE and nVHE) > > > > > > bikeshed: Personally, I find that range implies it takes an address as an > > > argument already. Maybe just call it __kvm_tlb_flush_vmid_range() > > > > > Hmm, since TLBI instructions takes-in a variety of ranges, VA or IPA, > > I just thought of extending the '_ipa' to make things clear. Moreover > > it aligns with the existing __kvm_tlb_flush_vmid_ipa(). WDYT? > > Like I said, just a bikeshed and it seemed trivial to eliminate a token > in the function name. FWIW, you're dealing in terms of the IPA space by > definition, as a VMID identifies an IPA address space. Range-based > invalidations by VA would instead take an ASID as the address space > identifier. > Okay, let's rename it to __kvm_tlb_flush_vmid_range(). Thanks, Raghavendra > -- > Thanks, > Oliver
