Re: [kvm-unit-tests PATCH v4] s390x/Makefile: refactor CPPFLAGS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nico Boehr <nrb@xxxxxxxxxxxxx> writes:

> Quoting Marc Hartmayer (2023-03-31 10:27:09)
>> This change makes it easier to reuse them. While at it, add a comment
>> why the `lib` include path is required.
>> 
>> Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx>
>> ---
>>  s390x/Makefile | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>> 
>> diff --git a/s390x/Makefile b/s390x/Makefile
>> index 71e6563bbb61..06720aace828 100644
>> --- a/s390x/Makefile
>> +++ b/s390x/Makefile
>> @@ -63,9 +63,14 @@ test_cases: $(tests)
>>  test_cases_binary: $(tests_binary)
>>  test_cases_pv: $(tests_pv_binary)
>>  
>> +INCLUDE_PATHS = $(SRCDIR)/lib $(SRCDIR)/lib/s390x
>> +# Include generated header files (e.g. in case of out-of-source builds)
>> +INCLUDE_PATHS += lib 
>
> Do you mind if I fix this up during picking?

Please fix it, thanks.

>
> ERROR: trailing whitespace
> #35: FILE: s390x/Makefile:68:
> +INCLUDE_PATHS += lib $
--
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux